New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watch files onbuild, even if build fails #3081
Merged
Merged
Commits on Aug 24, 2019
Commits on Aug 25, 2019
Commits on Aug 26, 2019
Commits on Aug 28, 2019
-
* Do not add files to Graph.watchFiles after all files have been loaded but immediately when starting to load them so that the same watchFile logic can be used for successful and unsuccessful builds (and files added by plugins are not ignored on errors) * Do not unwatch files that have been removed if an error occurred but only when a build has succeeded * Do not re-watch files of the previous build when an error occurred as those are still being watched; just additionally watch any files attached to the error * Make sure that watching a file automatically adds it to the list of "watched" files and only reset this list when clearing unneeded files * Remove logic to filter for absolute ids for now to restore the old behaviour * Replace some .forEach with for loops for slightly improved performance
-
Add watchFiles to errors not only when an explicit file position is
given but for any error that occurs during the build phase when there are already some watchFiles
-
-
-
-
-
Commits on Aug 29, 2019
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.