Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch files onbuild, even if build fails #3081

Merged
merged 20 commits into from Sep 8, 2019

Commits on Aug 24, 2019

  1. Copy the full SHA
    5679d0a View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2019

  1. Copy the full SHA
    7c003ac View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    2162dc7 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    a81204e View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    d3634fd View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    e825a44 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2019

  1. Copy the full SHA
    830e16b View commit details
    Browse the repository at this point in the history
  2. Better type checking

    mhkeller committed Aug 26, 2019
    Copy the full SHA
    edb85c2 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    dce2d78 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    d61f5f4 View commit details
    Browse the repository at this point in the history
  5. Better type checking

    mhkeller committed Aug 26, 2019
    Copy the full SHA
    d711ecf View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2019

  1. Improve watch behaviour

    * Do not add files to Graph.watchFiles after all files have been loaded
      but immediately when starting to load them so that the same watchFile
      logic can be used for successful and unsuccessful builds (and files
      added by plugins are not ignored on errors)
    * Do not unwatch files that have been removed if an error occurred but
      only when a build has succeeded
    * Do not re-watch files of the previous build when an error occurred as
      those are still being watched; just additionally watch any files
      attached to the error
    * Make sure that watching a file automatically adds it to the list of
      "watched" files and only reset this list when clearing unneeded files
    * Remove logic to filter for absolute ids for now to restore the old
      behaviour
    * Replace some .forEach with for loops for slightly improved performance
    lukastaegert committed Aug 28, 2019
    Copy the full SHA
    0cad1b9 View commit details
    Browse the repository at this point in the history
  2. Add watchFiles to errors not only when an explicit file position is

    given but for any error that occurs during the build phase when there
    are already some watchFiles
    lukastaegert committed Aug 28, 2019
    Copy the full SHA
    20a7944 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    5a242d2 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    96c8975 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    4d6cd53 View commit details
    Browse the repository at this point in the history
  6. Remove unused check

    lukastaegert committed Aug 28, 2019
    Copy the full SHA
    ec973d1 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    e2e0a27 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    3c70e73 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2019

  1. Copy the full SHA
    64180e9 View commit details
    Browse the repository at this point in the history