Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust bug template to mention REPL.it #3371

Merged
merged 2 commits into from Feb 7, 2020
Merged

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This will adjust the BUG issue template in two ways:

  • It mentions the REPL.it template used by the plugins repo as it is also valuable for Rollup core as it allows all options to be used
  • It requires a "reproduction link" as I believe ALL reproductions should be possible to be provided as some link. Would like to experiment how users react to that and if it improves provided reproductions.

Opinions?

@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #3371 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3371   +/-   ##
=======================================
  Coverage   93.27%   93.27%           
=======================================
  Files         172      172           
  Lines        6082     6082           
  Branches     1812     1812           
=======================================
  Hits         5673     5673           
  Misses        218      218           
  Partials      191      191

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c0417f...f8dd2ac. Read the comment docs.

@lukastaegert
Copy link
Member Author

I think I want to hold of merging this for now as I am not entirely happy about the REPL.it template. As it turns out, it will not automatically pick up generated files unless you have already added files with the same name, which is not good for code-splitting issues. I think I want to use an adjusted template that bundles to stdout instead and also contains some comments explaining this. @shellscape since it appears you control the @rollup username for repl.it, would you be able to make a template of mine "official" once I am happy with it?

@lukastaegert
Copy link
Member Author

@shellscape Could you fork this REPL into @rollup: https://repl.it/@lukastaegert/rollup-repro ?

@shellscape
Copy link
Contributor

Done! https://repl.it/@rollup/rollup-repro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants