Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing exports errors now print the importing module #3401

Merged
merged 4 commits into from Mar 6, 2020
Merged

Missing exports errors now print the importing module #3401

merged 4 commits into from Mar 6, 2020

Commits on Mar 6, 2020

  1. Missing exports errors now print the importing module 

    Prior to this change, we only printed the imported module
that failed, with no context on which module was attempting
the import. This could be difficult to debug in large codebases,
especially when importing commonly-used modules.
    Timothy Asquith committed Mar 6, 2020
    Copy the full SHA
    ac1782e View commit details
    Browse the repository at this point in the history

  2. rephrase missing export message 

    The phrasing attempts to match the "imported by" style
elsewhere in the codebase
    Timothy Asquith committed Mar 6, 2020
    Copy the full SHA
    3d081e5 View commit details
    Browse the repository at this point in the history

  3. Tests now expect new missing export message format

    Timothy Asquith committed Mar 6, 2020
    Copy the full SHA
    532610c View commit details
    Browse the repository at this point in the history

  4. Use relative module id when displaying missing export message

    Timothy Asquith committed Mar 6, 2020
    Copy the full SHA
    9c8764c View commit details
    Browse the repository at this point in the history