Track updates of globals that are exported as default

CHANGELOG.md

@@ -1,5 +1,14 @@
 # rollup changelog
 
+## 2.9.1
+*2020-05-11*
+
+### Bug Fixes
+* Do not create unintended live-bindings or invalid reexports when reexporting global variables (#3550)
+
+### Pull Requests
+* [#3550](https://github.com/rollup/rollup/pull/3550): Track updates of globals that are exported as default (@lukastaegert)
+
 ## 2.9.0
 *2020-05-10*
 

src/Module.ts

@@ -347,9 +347,7 @@ export default class Module {
 			} else if (variable instanceof ExportDefaultVariable) {
 				variable = variable.getOriginalVariable();
 			}
-			if (variable.module) {
-				relevantDependencies.add(variable.module);
-			}
+			relevantDependencies.add(variable.module!);
 		}
 		if (
 			this.isEntryPoint ||
@@ -363,9 +361,7 @@ export default class Module {
 				} else if (variable instanceof ExportDefaultVariable) {
 					variable = variable.getOriginalVariable();
 				}
-				if (variable.module) {
-					relevantDependencies.add(variable.module);
-				}
+				relevantDependencies.add(variable.module!);
 			}
 		}
 		if (this.graph.treeshakingOptions) {

src/ast/variables/GlobalVariable.ts

@@ -3,6 +3,8 @@ import { ObjectPath } from '../utils/PathTracker';
 import Variable from './Variable';
 
 export default class GlobalVariable extends Variable {
+	isReassigned = true;
+
 	hasEffectsWhenAccessedAtPath(path: ObjectPath) {
 		return !isGlobalMember([this.name, ...path]);
 	}

test/cli/samples/watch/bundle-error/_config.js

@@ -11,11 +11,11 @@ module.exports = {
 		fs.writeFileSync(mainFile, '<=>');
 	},
 	after() {
-		fs.unlinkSync(mainFile);
+		setTimeout(() => fs.unlinkSync(mainFile), 300);
 	},
 	abortOnStderr(data) {
 		if (data.includes('Error: Unexpected token')) {
-			setTimeout(() => fs.writeFileSync(mainFile, 'export default 42;'), 200);
+			setTimeout(() => fs.writeFileSync(mainFile, 'export default 42;'), 300);
 			return false;
 		}
 		if (data.includes('created _actual')) {

test/cli/samples/watch/watch-config-early-update/_config.js

@@ -60,7 +60,7 @@ module.exports = {
 		        `
 					);
 					fs.writeFileSync(messageFile, 'loaded');
-				}, 500);
+				}, 300);
 			}
 		});
 	},
@@ -69,7 +69,7 @@ module.exports = {
 	},
 	abortOnStderr(data) {
 		if (reloadTriggered && data.includes('created _actual')) {
-			return true;
+			return new Promise(resolve => setTimeout(() => resolve(true), 300));
 		} else if (data.includes('Reloading updated config')) {
 			reloadTriggered = true;
 			return false;

test/form/samples/export-default-global/_config.js

@@ -0,0 +1,4 @@
+module.exports = {
+	description: 'handles default exporting global variables',
+	options: { output: { name: 'bundle' } }
+};

test/form/samples/export-default-global/_expected/amd.js

@@ -0,0 +1,9 @@
+define(function () { 'use strict';
+
+	var value = global;
+
+	console.log(value);
+
+	return value;
+
+});

test/form/samples/export-default-global/_expected/cjs.js

@@ -0,0 +1,7 @@
+'use strict';
+
+var value = global;
+
+console.log(value);
+
+module.exports = value;

test/form/samples/export-default-global/_expected/es.js

@@ -0,0 +1,5 @@
+var value = global;
+
+console.log(value);
+
+export default value;

test/form/samples/export-default-global/_expected/iife.js

@@ -0,0 +1,10 @@
+var bundle = (function () {
+	'use strict';
+
+	var value = global;
+
+	console.log(value);
+
+	return value;
+
+}());

test/form/samples/export-default-global/_expected/system.js

@@ -0,0 +1,12 @@
+System.register('bundle', [], function (exports) {
+	'use strict';
+	return {
+		execute: function () {
+
+			var value = exports('default', global);
+
+			console.log(value);
+
+		}
+	};
+});

test/form/samples/export-default-global/_expected/umd.js

@@ -0,0 +1,13 @@
+(function (global, factory) {
+	typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :
+	typeof define === 'function' && define.amd ? define(factory) :
+	(global = global || self, global.bundle = factory());
+}(this, (function () { 'use strict';
+
+	var value = global;
+
+	console.log(value);
+
+	return value;
+
+})));

test/function/samples/default-exported-global/_config.js

@@ -0,0 +1,8 @@
+const assert = require('assert');
+
+module.exports = {
+	description: 'Tracks updates of default exported globals',
+	exports(exports) {
+		assert.deepStrictEqual(exports, { original: 1, updated: 2 });
+	}
+};

test/function/samples/default-exported-global/lib.js

@@ -0,0 +1,5 @@
+global.myGlobal = 1;
+export default myGlobal;
+global.myGlobal = 2;
+export const updated = myGlobal;
+delete global.myGlobal;

test/function/samples/default-exported-global/main.js

@@ -0,0 +1 @@
+export { default as original, updated } from './lib';