Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle some cases of duplicate export bindings #3575

Merged
merged 24 commits into from
Jun 7, 2020
Merged

Handle some cases of duplicate export bindings #3575

merged 24 commits into from
Jun 7, 2020

Commits on Jun 6, 2020

  1. Handle some cases of inlined exports and tests.

    @guybedford
    Joel Jeske authored and guybedford committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    03868b1 View commit details
    Browse the repository at this point in the history

  2. Consolidate test cases for discussion

    @guybedford
    Joel Jeske authored and guybedford committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    88e5642 View commit details
    Browse the repository at this point in the history

  3. fixup systen destructuring default assignment

    @guybedford
    guybedford committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    43169c0 View commit details
    Browse the repository at this point in the history

  4. fixup edge cases

    @guybedford
    guybedford committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    9d3583f View commit details
    Browse the repository at this point in the history

  5. wat

    @guybedford
    guybedford committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    666a630 View commit details
    Browse the repository at this point in the history

  6. remove safeExportName, exportName -> exportNames

    @guybedford
    guybedford committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    df2e9d3 View commit details
    Browse the repository at this point in the history

  7. First solution: Reset exportNames. Potentially dangerous.

    @lukastaegert @guybedford
    lukastaegert authored and guybedford committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    ea711d9 View commit details
    Browse the repository at this point in the history

  8. Remove exportNames property altogether and replace it by a map on C… 

    …hunk to avoid interactions between Chunks that export the same variables, and interactions between outputs
    @lukastaegert @guybedford
    lukastaegert authored and guybedford committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    31f26c8 View commit details
    Browse the repository at this point in the history

  9. Polish output cases

    @guybedford
    guybedford committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    5f89362 View commit details
    Browse the repository at this point in the history

  10. remove unused

    @guybedford
    guybedford committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    056bee7 View commit details
    Browse the repository at this point in the history

  11. ws refactor

    @guybedford
    guybedford committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    0a9d222 View commit details
    Browse the repository at this point in the history

  12. further ws refactor

    @guybedford
    guybedford committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    6ff19a8 View commit details
    Browse the repository at this point in the history

  13. fixup assign space

    @guybedford
    guybedford committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    ba5c92d View commit details
    Browse the repository at this point in the history

  14. Fix linting

    @lukastaegert
    lukastaegert committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    76a820e View commit details
    Browse the repository at this point in the history

  15. Improve coverage

    @lukastaegert
    lukastaegert committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    0f7d4a2 View commit details
    Browse the repository at this point in the history

  16. Improve coverage

    @lukastaegert
    lukastaegert committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    b35d6c5 View commit details
    Browse the repository at this point in the history

  17. further refinements

    @guybedford
    guybedford committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    5d37459 View commit details
    Browse the repository at this point in the history

  18. further refinements, converage

    @guybedford
    guybedford committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    3d1ed76 View commit details
    Browse the repository at this point in the history

  19. fixup imports

    @guybedford
    guybedford committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    1fc3cb0 View commit details
    Browse the repository at this point in the history

  20. Improve coverage

    @lukastaegert
    lukastaegert committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    bac6f63 View commit details
    Browse the repository at this point in the history

  21. refactor ws handling

    @guybedford
    guybedford committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    e973ead View commit details
    Browse the repository at this point in the history

  22. inline variable

    @guybedford
    guybedford committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    c6ab411 View commit details
    Browse the repository at this point in the history

  23. scanWs refactor

    @guybedford
    guybedford committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    dd93730 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2020

  1. Make name somewhat clearer

    @lukastaegert
    lukastaegert committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    f2e4f1d View commit details
    Browse the repository at this point in the history