Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly construct namespace when dynamically importing chunks with facades in default export mode #3709

Merged
merged 1 commit into from
Aug 7, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Chunk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1081,7 +1081,10 @@ export default class Chunk {
if (chunk === this) {
node.setInternalResolution(resolution.namespace);
} else {
node.setExternalResolution(chunk!.exportMode, resolution);
node.setExternalResolution(
this.facadeChunkByModule.get(resolution)?.exportMode || chunk!.exportMode,
resolution
);
}
} else {
node.setExternalResolution('auto', resolution);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
const assert = require('assert');

module.exports = {
description: 'handles dynamic imports from facades using default export mode',
options: {
input: ['main', 'foo', 'bar']
},
exports(exports) {
return exports.then(exported => assert.deepStrictEqual(exported, { default: 4 }));
}
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import foo from './foo.js';
import square from './square.js';
export default square(3) + foo;
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
import square from './square.js';
export default square(2);
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export default import('./foo.js');
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export default x => x * x;