Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly deconflict synthetic named exports #3747

Merged
merged 1 commit into from Aug 27, 2020

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3746

Description

As it turned out, synthetic named exports were not properly fed into the deconflicting algorithm. This is fixed here.

@rollup-bot
Copy link
Collaborator

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-3746-synthetic-export-name-conflict

or load it into the REPL:
https://rollupjs.org/repl/?circleci=12714

@lukastaegert lukastaegert merged commit da9195d into master Aug 27, 2020
@lukastaegert lukastaegert deleted the gh-3746-synthetic-export-name-conflict branch August 27, 2020 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variables conflict: imported module and local variable have the same name
2 participants