Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update documentation on configuring Babel #3818

Merged
merged 1 commit into from Oct 12, 2020

Conversation

Robin-Hoodie
Copy link
Contributor

@Robin-Hoodie Robin-Hoodie commented Oct 10, 2020

Updated documentation on configuring Babel removing the section on passing '{"modules": false}' as that is no longer needed since Babel 7

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers: #3717

Description

I'm not sure if I should add some documentation on using {"modules": false} for Babel <7, what do you think?

@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #3818 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3818   +/-   ##
=======================================
  Coverage   97.05%   97.05%           
=======================================
  Files         185      185           
  Lines        6482     6482           
  Branches     1877     1877           
=======================================
  Hits         6291     6291           
  Misses        101      101           
  Partials       90       90           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4f8196...f046307. Read the comment docs.

@TrySound TrySound changed the title feat: Update documentation on configuring Babel, removing the section… feat: Update documentation on configuring Babel Oct 10, 2020
… on passing '{"modules": false}' as that is no longer needed since Babel 7. Closes rollup#3717
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukastaegert lukastaegert merged commit 53493f6 into rollup:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants