Return hook result inside promise with async timer end #4010
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4010 +/- ##
==========================================
- Coverage 97.24% 97.21% -0.03%
==========================================
Files 192 192
Lines 6760 6762 +2
Branches 1973 1973
==========================================
Hits 6574 6574
- Misses 99 101 +2
Partials 87 87
Continue to review full report at Codecov.
|
|
Reminds me, we should think about a testing strategy for this option |
|
Apologies for the issue, it was really obvious and I missed it 😭 |
SuperOleg39
referenced
this pull request
Jan 18, 2022
* refactor: performance timers for node.js and browser * simplify, add return types * refactor: replace object with array * refactor: replace fn.apply with spread * refactor: use map * nit * export performance object * type fixes * fix browser perf test, add comment * export entire process object * remove type assertion in rollup.config * remove comment * extract interface * check for performance object in alternative environments Co-authored-by: Lukas Taegert-Atkinson <lukastaegert@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Fix after #4004
Description
#4004 replace plugin hooks result promises, and forget to return original promises payload.
For this reason, rollup builds with
perfoption, and with@rollup/plugin-typescriptfor example, was broken - becauseloadplugin hook can return modified input, and this input has been discarded.