Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Export defineConfig defines the auxiliary function of the configuration #4126

Closed
wants to merge 4 commits into from

Conversation

rxliuli
Copy link
Contributor

@rxliuli rxliuli commented Jun 6, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers: #4125

Description

@github-actions
Copy link

github-actions bot commented Jun 6, 2021

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rxliuli/rollup#master

or load it into the REPL:
https://rollupjs.org/repl/?pr=4126

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR, I think this would make a useful addition. Two points:

  • Could you fork your PR from master instead of the treeshake-presets branch? That one is still incomplete and not ready for release, so this will block your PR.
  • If we add this, we should also document it somewhere on the website (i.e. in the docs folder). Probably similar to what they have on the Vite site (except that we do not directly support TypeScript), somewhere in 01-command-line-reference

@rxliuli
Copy link
Contributor Author

rxliuli commented Jun 6, 2021

Hi, thanks for the PR, I think this would make a useful addition. Two points:

  • Could you fork your PR from instead of the branch? That one is still incomplete and not ready for release, so this will block your PR.master``treeshake-presets
  • If we add this, we should also document it somewhere on the website (i.e. in the folder). Probably similar to what they have on the Vite site (except that we do not directly support TypeScript), somewhere in 01-command-line-referencedocs

Wait a minute, let me revise it and raise a PR again

@rxliuli rxliuli closed this Jun 6, 2021
@lukastaegert
Copy link
Member

You could also just have force-pushed to your branch :)

@rxliuli
Copy link
Contributor Author

rxliuli commented Jun 6, 2021

You could also just have force-pushed to your branch :)

I created a new PR: #4127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants