Restrict parallel execution of load hook. #4200
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Follow up to #4170
I had more "EMFILE: too many open files" errors in another project and realized the reason for this that the fix in #4170 does not apply when a load hook is provided. We can assume that load hooks will often use fs.readFile as well and therefore be subject to the same problem with too many parallel file read. I think it makes sense to extend the scope of the readQueue and also channel the load hook through it.