Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typescript bug class field initialization order #4236

Merged
merged 2 commits into from Nov 1, 2021

Conversation

dnalborczyk
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no (using existing)

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

just a future safe enhancement, see: microsoft/TypeScript#45995

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #4236 (a9783fe) into master (ce3de49) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4236   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files         204      204           
  Lines        7283     7283           
  Branches     2079     2079           
=======================================
  Hits         7166     7166           
  Misses         58       58           
  Partials       59       59           
Impacted Files Coverage Δ
src/Module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce3de49...a9783fe. Read the comment docs.

@lukastaegert lukastaegert merged commit 73c10cd into rollup:master Nov 1, 2021
@dnalborczyk dnalborczyk deleted the fix-property-init branch November 2, 2021 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants