New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump deps #4293
chore: bump deps #4293
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4293 +/- ##
==========================================
+ Coverage 98.40% 98.42% +0.02%
==========================================
Files 204 205 +1
Lines 7319 7317 -2
Branches 2084 2083 -1
==========================================
Hits 7202 7202
+ Misses 58 57 -1
+ Partials 59 58 -1
Continue to review full report at Codecov.
|
b0b291d
to
d287299
Compare
da44227
to
16803f0
Compare
8c622b4
to
f06d2fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good, only thing I wonder about is how you managed to updated mocha without the Node 10 tests breaking. But I guess if it works, awesome, as these are just dev dependencies, no harm done. Reminds me to put some steam behind that Rollup 3 release soon...
I think a lot of times it just means that the "support" is dropped by excluding that version from the ci. as long as not any non-supported js syntax, js api or node.js api is being used it should keep working. once it does use unsupported features, we can pin that specific version.
have you started in some branch already? |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
acorn
v8.6.0 added support forergonomic brand checks for private fields
#4292