Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use set for reserved words #4298

Merged
merged 1 commit into from Dec 11, 2021

Conversation

dnalborczyk
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

@codecov
Copy link

codecov bot commented Dec 11, 2021

Codecov Report

Merging #4298 (0aaa271) into master (49d41f7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4298   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files         205      205           
  Lines        7311     7311           
  Branches     2082     2082           
=======================================
  Hits         7198     7198           
  Misses         55       55           
  Partials       58       58           
Impacted Files Coverage Δ
src/utils/exportNames.ts 100.00% <100.00%> (ø)
src/utils/generateCodeSnippets.ts 97.29% <100.00%> (ø)
src/utils/reservedNames.ts 100.00% <100.00%> (ø)
src/utils/safeName.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49d41f7...0aaa271. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sure this will be slightly slower from a performance perspective (because object access is incredibly fast, especially if the object is never mutated and initialized with a literal) but I guess it will not be noticeable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants