refactor: re-use reserved names set #4304
Conversation
dnalborczyk
force-pushed
the
reserved-words
branch
from
2bcd6e9
to
93b0276
Compare
Codecov Report
@@ Coverage Diff @@
## master #4304 +/- ##
==========================================
- Coverage 98.44% 98.44% -0.01%
==========================================
Files 205 205
Lines 7316 7314 -2
Branches 2084 2084
==========================================
- Hits 7202 7200 -2
Misses 55 55
Partials 59 59
Continue to review full report at Codecov.
|
dnalborczyk
force-pushed
the
reserved-words
branch
from
e86d969
to
23dff43
Compare
src/utils/BUILTINS.ts
Outdated
| 'uneval' | ||
| ]); | ||
|
|
||
| export default BUILTINS; |
There was a problem hiding this comment.
Actually looking at what we use this for, i.e. generating "safe" variable names, I do not think we need to keep global variables in this list. Their use is already tracked so that generated variable names are deconflicted. Looking at what is left then, I wonder if we could not just merge that into the RESERVED_WORDS list (I actually only see NaN)
src/utils/identifierHelpers.ts
Outdated
|
|
||
| const blacklisted = new Set(reservedWords.concat(builtins)); | ||
| const blacklisted = new Set([...RESERVED_WORDS, ...BUILTINS]); |
There was a problem hiding this comment.
If you follow my suggestion of just merging the lists, then we do not need this awkwardly named variable any more. But please tell me if you think I am overlooking something.
|
@lukastaegert sorry, just saw this, makes sense to me. 👍 |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description