Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix git line breaks on windows #4306

Merged
merged 1 commit into from Dec 18, 2021
Merged

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Dec 17, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

If I remember correctly, this fixes git line breaks for all windows users, not just the ci.

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #4306 (22efec1) into master (28cc198) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4306   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files         205      205           
  Lines        7311     7311           
  Branches     2082     2082           
=======================================
  Hits         7198     7198           
  Misses         55       55           
  Partials       58       58           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28cc198...22efec1. Read the comment docs.

@dnalborczyk dnalborczyk changed the title test build: fix git line breaks on windows Dec 17, 2021
@dnalborczyk dnalborczyk changed the title build: fix git line breaks on windows ci: fix git line breaks on windows Dec 17, 2021
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a shot

@lukastaegert lukastaegert merged commit 5d43bd6 into rollup:master Dec 18, 2021
@dnalborczyk dnalborczyk deleted the build branch December 22, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants