Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add macos to pipeline #4307

Merged
merged 4 commits into from Dec 22, 2021
Merged

ci: add macos to pipeline #4307

merged 4 commits into from Dec 22, 2021

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Dec 17, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

ref: #4300

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #4307 (4298516) into master (48f0e31) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4307   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files         205      205           
  Lines        7316     7316           
  Branches     2084     2084           
=======================================
  Hits         7202     7202           
  Misses         55       55           
  Partials       59       59           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48f0e31...4298516. Read the comment docs.

@kzc
Copy link
Contributor

kzc commented Dec 17, 2021

Thanks.

Note to @lukastaegert: PR #4308 should be merged before PR #4307.

runs-on: macos-latest
strategy:
matrix:
node: ['10', '12', '14', '16', '17']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you really sure we need all those versions? Not sure in how far this uses up contingents we get from Github, but also, what bugs do you expect to find here except make CI runs potentially slower? IMO it should be enough to do all relevant versions for the fastest OS (which is Linux on CI), which should handle the subtle version differences, and only do the oldest supported and latest supported for MacOS and Windows.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what the GH actions usage limit for OSS is actually. but as far as I know, modules are usually tested against the latest LTS versions on multiple operating systems. but it's all up to the developer to decide.

testing the earliest supported LTS and the latest supported LTS plus latest version is probably fine tho.
since it's free, and just some settings, I'd personally go for all. it might not apply to rollup (or it might), but there are sometimes some small intricacies between node versions.

@kzc
Copy link
Contributor

kzc commented Dec 22, 2021

When testing against 48f0e31, node v10.x does not run npm test reliably on my Mac. Node v12, v14 and v16 do run successfully. I think running rollup tests against node v10 is a lost cause on Mac.

My personal preference would be to run the latest stable node v16 on Mac rather than the unstable node v17, as more users use the former.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants