Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fsevents integration #4312

Merged
merged 2 commits into from Dec 22, 2021
Merged

fix: fsevents integration #4312

merged 2 commits into from Dec 22, 2021

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Dec 21, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

thanks @kzc for digging into this!

ref:
#4300 (comment)
#4300 (comment)

also took the liberty to convert loadFsEvents to an async function

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #4312 (64c96a9) into master (83af3aa) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4312      +/-   ##
==========================================
- Coverage   98.45%   98.44%   -0.02%     
==========================================
  Files         205      205              
  Lines        7314     7316       +2     
  Branches     2083     2084       +1     
==========================================
+ Hits         7201     7202       +1     
  Misses         55       55              
- Partials       58       59       +1     
Impacted Files Coverage Δ
src/watch/fsevents-importer.ts 66.66% <100.00%> (-8.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83af3aa...64c96a9. Read the comment docs.

@kzc
Copy link
Contributor

kzc commented Dec 21, 2021

I think build-plugins/conditional-fsevents-import should be removed altogether.

Please see: #4300 (comment)

@lukastaegert lukastaegert merged commit 48f0e31 into rollup:master Dec 22, 2021
@dnalborczyk dnalborczyk deleted the fsevents branch December 22, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants