Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove non-existing static functions from known globals #4313

Merged
merged 3 commits into from Dec 23, 2021

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Dec 21, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

they do not exist in Chrome (node.js), Firefox, Safari, and never heard of these either:

getNotifier: I'm guessing something which didn't find it's way into the language api: http://man.hubwiz.com/docset/JavaScript.docset/Contents/Resources/Documents/developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/getNotifier.html

getOwn: did not find any docs

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #4313 (5201696) into master (84d2382) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4313   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files         205      205           
  Lines        7316     7316           
  Branches     2084     2084           
=======================================
  Hits         7202     7202           
  Misses         55       55           
  Partials       59       59           
Impacted Files Coverage Δ
src/ast/nodes/shared/knownGlobals.ts 92.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84d2382...5201696. Read the comment docs.

@lukastaegert lukastaegert merged commit 9927fda into rollup:master Dec 23, 2021
@dnalborczyk dnalborczyk deleted the globals-remove branch December 29, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants