New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use fs, fs-extra, remove sander #4319
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4319 +/- ##
=======================================
Coverage 98.70% 98.70%
=======================================
Files 205 205
Lines 7320 7320
Branches 2083 2083
=======================================
Hits 7225 7225
Misses 35 35
Partials 60 60 Continue to review full report at Codecov.
|
0b440a8
to
11a2ff8
Compare
f7c0347
to
8461d20
Compare
5a1612c
to
c2218af
Compare
#4318 replaces |
In an experiment, replacing |
I spoke too soon - here's a rare node16/macos failure in the commits of this PR: https://github.com/rollup/rollup/runs/4634674788?check_suite_focus=true |
d8c6dff
to
465b77b
Compare
yeah, I didn't think the watch failures would go away with this. I agree with you that the timing and execution of the tests is likely at fault. I wanted to look after the last commits at the failures and/or wait for the other PR first. I went a little further and made this PR also fully async. |
8c9bd6d
to
c4ea044
Compare
I like the idea of getting rid of sander, but maybe you are trying too much here by "fixing everything". Why not limit this one to replacing sander for now but keep especially the structure of the watch tests intact, and then improve them separately? |
good point. I haven't looked at this PR for a while because of the mac os ci failures. |
@lukastaegert this should be good to go |
5ed64c7
to
cd505fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👍
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description