Create a shallow copy when returning meta from resolveId #4347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
When returning a meta object from a resolveId hook, Rollup would use this object as the meta property of a module. As it turned out, this is not only inconsistent with the
load
andtransform
hooks (where the object is merged shallowly) but also causes unexpected behaviour. E.g., the meta object returned from aresolveId
hook can not be safely reused for other modules. But more importantly, it is unsafe to cache the return value ofthis.resolve
as the associatedmeta
property can change later on. This is fixed here.The issue turned up in rollup/plugins#1038