Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the error prompt and output the error file name #4421

Merged
merged 3 commits into from Mar 2, 2022
Merged

Improve the error prompt and output the error file name #4421

merged 3 commits into from Mar 2, 2022

Conversation

caoxiemeihao
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

It prompts me when I use rollup.

Module format cjs does not support top-level await. Use the "es" or "system" output formats rather.

But I don't know which file this error comes from.
I want it to prompt me for specific file.

Module format cjs does not support top-level await. Use the "es" or "system" output formats rather.
file: /Users/atom/Desktop/github/electron-vue-vite/packages/main/samples/execa.ts

@caoxiemeihao caoxiemeihao reopened this Mar 1, 2022
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like a good improvement! If fixed the test and changed it slightly to avoid the TypeScript non-null assertion, this is good to go from my side.

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #4421 (fcd893c) into master (0b60dd8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4421   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files         204      204           
  Lines        7308     7308           
  Branches     2080     2080           
=======================================
  Hits         7217     7217           
  Misses         33       33           
  Partials       58       58           
Impacted Files Coverage Δ
src/Chunk.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b60dd8...fcd893c. Read the comment docs.

@caoxiemeihao
Copy link
Contributor Author

You're right. I'm glad to get your help. 😄

@lukastaegert lukastaegert enabled auto-merge (squash) March 2, 2022 12:59
@lukastaegert lukastaegert merged commit 5a53919 into rollup:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants