Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: github issue #4439: case insensitive compare of file paths. #4440

Closed
wants to merge 6 commits into from
Closed

fix: github issue #4439: case insensitive compare of file paths. #4440

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d999de4
fix: github issue #4439
lovettchris Mar 11, 2022
0123d45
fix one more regex so it matches all drive letter cases.
lovettchris Mar 11, 2022
6f13e3d
fix: CR feedback on rollup.isSamePath
lovettchris Mar 11, 2022
925eb79
revert changes to package-lock.json.
lovettchris Mar 11, 2022
f06a827
fix: revert newline at end of file.
lovettchris Mar 11, 2022
97ffdc6
Merge branch 'master' into clovett/win32_path_compare
lukastaegert Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion cli/run/loadConfigFile.ts
View file
Open in desktop
Expand Up @@ -8,6 +8,7 @@ import { bold } from '../../src/utils/colors';
import { error } from '../../src/utils/error';
import { mergeOptions } from '../../src/utils/options/mergeOptions';
import type { GenericConfigObject } from '../../src/utils/options/options';
import { isSamePath } from '../../src/utils/path';
import relativeId from '../../src/utils/relativeId';
import { stderr } from '../logging';
import batchWarnings, { type BatchWarnings } from './batchWarnings';
Expand Down Expand Up @@ -108,7 +109,7 @@ async function loadConfigFromBundledFile(fileName: string, bundledCode: string):
const extension = extname(resolvedFileName);
const defaultLoader = require.extensions[extension];
require.extensions[extension] = (module: NodeModule, requiredFileName: string) => {
if (requiredFileName === resolvedFileName) {
if (isSamePath(requiredFileName, resolvedFileName)) {
(module as NodeModuleWithCompile)._compile(bundledCode, requiredFileName);
} else {
defaultLoader(module, requiredFileName);
Expand Down