Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree shake parameter defaults #4498

Merged
merged 15 commits into from May 19, 2022
Merged

Tree shake parameter defaults #4498

merged 15 commits into from May 19, 2022

Commits on May 14, 2022

  1. Implement basic support for parameter default tree-shaking

    @lukastaegert
    lukastaegert committed May 14, 2022
    Copy the full SHA
    2ca6a08 View commit details
    Browse the repository at this point in the history

  2. Refine parameter default tree-shaking 

    * Use an inclusion parameter instead of separate methods to handle this
* Make call argument inclusion path aware so that in the future, we can use
  this mechanism to determine possible values for parameters for deoptimization
* Support parameter default treeshaking for functions, object and class methods,
  functions in array tuples and template tags
* Use full CallExpression logic for TaggedTemplateExpression
    @lukastaegert
    lukastaegert committed May 14, 2022
    Copy the full SHA
    ae05671 View commit details
    Browse the repository at this point in the history

  3. Use optional chaining instead of null checks

    @lukastaegert
    lukastaegert committed May 14, 2022
    Copy the full SHA
    c26653b View commit details
    Browse the repository at this point in the history

  4. Always call applyDeoptimizations both in hasEffects and include

    @lukastaegert
    lukastaegert committed May 14, 2022
    Copy the full SHA
    3431aa0 View commit details
    Browse the repository at this point in the history

  5. Add more tests

    @lukastaegert
    lukastaegert committed May 14, 2022
    Copy the full SHA
    0d5119d View commit details
    Browse the repository at this point in the history

  6. Replace includeAsStatement with parameter

    @lukastaegert
    lukastaegert committed May 14, 2022
    Copy the full SHA
    6c4c0c7 View commit details
    Browse the repository at this point in the history

  7. Revert previous because it is handled via NodeBase

    @lukastaegert
    lukastaegert committed May 14, 2022
    Copy the full SHA
    bc60156 View commit details
    Browse the repository at this point in the history

  8. Ensure properties are deoptimized by default

    @lukastaegert
    lukastaegert committed May 14, 2022
    Copy the full SHA
    9b71326 View commit details
    Browse the repository at this point in the history

  9. Track calls through possible TDZ violations

    @lukastaegert
    lukastaegert committed May 14, 2022
    Copy the full SHA
    1888f1e View commit details
    Browse the repository at this point in the history

Commits on May 15, 2022

  1. Improve coverage

    @lukastaegert
    lukastaegert committed May 15, 2022
    Copy the full SHA
    eda4b61 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. Remove defaults without side effects for unused parameters

    @lukastaegert
    lukastaegert committed May 17, 2022
    Copy the full SHA
    a325e95 View commit details
    Browse the repository at this point in the history

  2. Check for unknown values via typeof to prepare for different types of… 

    … unknown
    @lukastaegert
    lukastaegert committed May 17, 2022
    Copy the full SHA
    a9597e2 View commit details
    Browse the repository at this point in the history

  3. Remove defaults when passing non-literal values

    @lukastaegert
    lukastaegert committed May 17, 2022
    Copy the full SHA
    511e10d View commit details
    Browse the repository at this point in the history

  4. Deoptimize this for tagged template expression 

    and improve coverage
    @lukastaegert
    lukastaegert committed May 17, 2022
    Copy the full SHA
    ed09fd8 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. Merge branch 'master' into tree-shake-parameter-defaults

    @lukastaegert
    lukastaegert committed May 19, 2022
    Copy the full SHA
    d035821 View commit details
    Browse the repository at this point in the history