Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure parameter defaults are deoptimized #4515

Merged
merged 1 commit into from May 29, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ast/nodes/ArrowFunctionExpression.ts
Expand Up @@ -25,6 +25,7 @@ export default class ArrowFunctionExpression extends FunctionBase {
}

hasEffects(): boolean {
if (!this.deoptimized) this.applyDeoptimizations();
return false;
}

Expand Down
11 changes: 11 additions & 0 deletions src/ast/nodes/shared/FunctionBase.ts
Expand Up @@ -175,6 +175,7 @@ export default abstract class FunctionBase extends NodeBase implements Deoptimiz
includeChildrenRecursively: IncludeChildren,
{ includeWithoutParameterDefaults }: InclusionOptions = BLANK
): void {
if (!this.deoptimized) this.applyDeoptimizations();
this.included = true;
const { brokenFlow } = context;
context.brokenFlow = BROKEN_FLOW_NONE;
Expand Down Expand Up @@ -244,6 +245,16 @@ export default abstract class FunctionBase extends NodeBase implements Deoptimiz
super.parseNode(esTreeNode);
}

protected applyDeoptimizations() {
// We currently do not track deoptimizations of default values, deoptimize them
// just as we deoptimize call arguments
for (const param of this.params) {
if (param instanceof AssignmentPattern) {
param.right.deoptimizePath(UNKNOWN_PATH);
}
}
}

protected abstract getObjectEntity(): ObjectEntity;
}

Expand Down
1 change: 1 addition & 0 deletions src/ast/nodes/shared/FunctionNode.ts
Expand Up @@ -39,6 +39,7 @@ export default class FunctionNode extends FunctionBase {
}

hasEffects(): boolean {
if (!this.deoptimized) this.applyDeoptimizations();
return !!this.id?.hasEffects();
}

Expand Down
@@ -0,0 +1,3 @@
module.exports = {
description: 'deoptimizes functions supplied as default values'
};
@@ -0,0 +1,4 @@
const foo = (a = 'fallback') => a;
const bar = (a = foo) => a;

assert.strictEqual(bar()(), 'fallback');