Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor side effect handling for property interactions #4522

Merged
merged 13 commits into from Jun 7, 2022
Merged

Refactor side effect handling for property interactions #4522

merged 13 commits into from Jun 7, 2022

Commits on Jun 7, 2022

  1. Rename event -> interaction

    @lukastaegert
    lukastaegert committed Jun 7, 2022
    Copy the full SHA
    a39dc4e View commit details
    Browse the repository at this point in the history

  2. Refactor MemberExpression assignment logic to prepare for new interac… 

    …tions
    @lukastaegert
    lukastaegert committed Jun 7, 2022
    Copy the full SHA
    ffc4888 View commit details
    Browse the repository at this point in the history

  3. Use objects for interactions

    @lukastaegert
    lukastaegert committed Jun 7, 2022
    Copy the full SHA
    b700a02 View commit details
    Browse the repository at this point in the history

  4. Add additional interaction parameters

    @lukastaegert
    lukastaegert committed Jun 7, 2022
    Copy the full SHA
    b40eab3 View commit details
    Browse the repository at this point in the history

  5. Pick "this"-argument from interaction

    @lukastaegert
    lukastaegert committed Jun 7, 2022
    Copy the full SHA
    443a937 View commit details
    Browse the repository at this point in the history

  6. Use interaction for getReturnExpression

    @lukastaegert
    lukastaegert committed Jun 7, 2022
    Copy the full SHA
    34636f5 View commit details
    Browse the repository at this point in the history

  7. Replace dedicated methods with hasEffectsOnInteractionAtPath

    @lukastaegert
    lukastaegert committed Jun 7, 2022
    Copy the full SHA
    1696462 View commit details
    Browse the repository at this point in the history

  8. Fix accessor handling for loops and updated expressions

    @lukastaegert
    lukastaegert committed Jun 7, 2022
    Copy the full SHA
    6503fd0 View commit details
    Browse the repository at this point in the history

  9. Simplify assignment handling

    @lukastaegert
    lukastaegert committed Jun 7, 2022
    Copy the full SHA
    b2dc098 View commit details
    Browse the repository at this point in the history

  10. Change assignment to use args property

    @lukastaegert
    lukastaegert committed Jun 7, 2022
    Copy the full SHA
    a3e4baa View commit details
    Browse the repository at this point in the history

  11. Simplify ObjectEntity effect handling

    @lukastaegert
    lukastaegert committed Jun 7, 2022
    Copy the full SHA
    981498e View commit details
    Browse the repository at this point in the history

  12. Cache remaining interactions that may be cached

    @lukastaegert
    lukastaegert committed Jun 7, 2022
    Copy the full SHA
    e8247bd View commit details
    Browse the repository at this point in the history

  13. Improve coverage

    @lukastaegert
    lukastaegert committed Jun 7, 2022
    Copy the full SHA
    605c701 View commit details
    Browse the repository at this point in the history