New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3.0] use compiler target ES2020 #4651
[v3.0] use compiler target ES2020 #4651
Conversation
Codecov Report
@@ Coverage Diff @@
## release-3.0.0 #4651 +/- ##
=================================================
+ Coverage 98.97% 99.04% +0.07%
=================================================
Files 213 213
Lines 7481 7472 -9
Branches 2112 2066 -46
=================================================
- Hits 7404 7401 -3
Misses 23 23
+ Partials 54 48 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://node.green, we are still missing spread operators after optional chaining for this setting.
interestingly what you are pointing to was a bug in V8 which was fixed in a later iteration: microsoft/TypeScript#46325 if you find yourself or a contributor using that syntax (which is probably fairly unlikely) you could still switch back to |
I guess considering our stellar E2E test coverage and the fact that CI runs the tests at the exact earliest version we promise to support, it is probably safe to go for ES2020 |
This PR has been released as part of rollup@3.0.0-8. Note that this is a pre-release, so to test it, you need to install Rollup via |
This PR has been released as part of rollup@3.0.0. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping
Transpiled code should get smaller (nullish coalescing, optional chaining) and run at native speed.