Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unicorn linting rules #4666

Merged
merged 1 commit into from Oct 12, 2022
Merged

Add unicorn linting rules #4666

merged 1 commit into from Oct 12, 2022

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This adds a wide list of plugins from eslint-plugin-unicorn. Most of them have auto-fixers, and they ensure things like using node: prefixes for builtin imports.

@github-actions
Copy link

github-actions bot commented Oct 12, 2022

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#more-lint-rules

or load it into the REPL:
https://rollupjs.org/repl/?pr=4666

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #4666 (5049c95) into master (4fdf8bd) will decrease coverage by 0.00%.
The diff coverage is 98.27%.

@@            Coverage Diff             @@
##           master    #4666      +/-   ##
==========================================
- Coverage   99.06%   99.05%   -0.01%     
==========================================
  Files         214      214              
  Lines        7558     7549       -9     
  Branches     2097     2093       -4     
==========================================
- Hits         7487     7478       -9     
  Misses         23       23              
  Partials       48       48              
Impacted Files Coverage Δ
browser/src/path.ts 78.57% <ø> (ø)
cli/cli.ts 50.00% <ø> (ø)
cli/run/timings.ts 0.00% <0.00%> (ø)
src/ast/NodeInteractions.ts 100.00% <ø> (ø)
src/ast/nodes/ExpressionStatement.ts 87.50% <ø> (ø)
src/ast/nodes/ImportExpression.ts 100.00% <ø> (ø)
src/ast/nodes/Literal.ts 100.00% <ø> (ø)
src/ast/nodes/LogicalExpression.ts 100.00% <ø> (ø)
src/ast/nodes/ObjectExpression.ts 100.00% <ø> (ø)
src/ast/nodes/PropertyDefinition.ts 100.00% <ø> (ø)
... and 111 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit 3cb7f13 into master Oct 12, 2022
@lukastaegert lukastaegert deleted the more-lint-rules branch October 12, 2022 14:13
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.2.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants