Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nested plugin in options stage #4668

Merged
merged 2 commits into from Oct 14, 2022
Merged

fix: nested plugin in options stage #4668

merged 2 commits into from Oct 14, 2022

Conversation

sxzz
Copy link
Contributor

@sxzz sxzz commented Oct 12, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

I was missing some places of the normalizing plugins before.

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #4668 (454548c) into master (a1f9e4b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4668   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files         214      214           
  Lines        7548     7548           
  Branches     2092     2092           
=======================================
  Hits         7477     7477           
  Misses         23       23           
  Partials       48       48           
Impacted Files Coverage Δ
src/rollup/rollup.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sxzz sxzz mentioned this pull request Oct 12, 2022
9 tasks
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@sxzz sxzz mentioned this pull request Oct 13, 2022
9 tasks
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@lukastaegert lukastaegert merged commit 53de5b0 into rollup:master Oct 14, 2022
@sxzz sxzz deleted the fix/nested-plugin branch October 14, 2022 04:40
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.2.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants