Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix perf script for object hooks #4707

Merged
merged 1 commit into from Nov 11, 2022
Merged

Fix perf script for object hooks #4707

merged 1 commit into from Nov 11, 2022

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This is just a small improvement for the perf option to not fail when object hooks are used. Also fixes some issues with the perf script.

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix-perf

or load it into the REPL:
https://rollupjs.org/repl/?pr=4707

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #4707 (609879a) into master (7307bfa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4707   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files         215      215           
  Lines        7593     7597    +4     
  Branches     2105     2106    +1     
=======================================
+ Hits         7519     7523    +4     
  Misses         24       24           
  Partials       50       50           
Impacted Files Coverage Δ
src/utils/timers.ts 92.72% <100.00%> (+0.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit e228fc7 into master Nov 11, 2022
@lukastaegert lukastaegert deleted the fix-perf branch November 11, 2022 19:20
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.3.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants