New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add exports
and exportedBindings
to Module
class
#4731
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4731 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 217 217
Lines 7690 7698 +8
Branches 2126 2128 +2
=======================================
+ Hits 7616 7624 +8
Misses 24 24
Partials 50 50
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I think for this specific topic, the existing test changes should cover it. |
test/function/samples/check-exports-exportedBindings-when-export-all-source/main.js
Outdated
Show resolved
Hide resolved
e50bd5c
to
a779d51
Compare
Now to finish the feature, we need to add it to the documentation. In this case, it is only necessary in the section about |
Done, if some descriptions are inaccurate, plz let me know. |
e533d78
to
b263338
Compare
b263338
to
c0462a3
Compare
Thank you very much for your work on this and sticking with me! Will put this into a release. If you are interested, I put the "PR welcome" label on some of the most recent issues. On some of them, I added a comment what I would expect the "fix" should be. If you are interested, just pick any of them. Feel free to ping me if you want further guidance. Again, thank you so much for your work so far! |
Wow, I'm interested in contributing to rollup, I will look at these issues. I learned a lot from this PR with your guidance, thank you very much 😄. |
This PR has been released as part of rollup@3.6.0. You can test it via |
This PR contains:
Are tests included?
@lukastaegert Could you recommend a file location where I can write tests for this pr?
Breaking Changes?
List any relevant issue numbers:
resolves #4721
Description
expose
exports
andexportedBindings
for use in some hooks.