Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps #4778

Merged
merged 13 commits into from Jan 2, 2023
Merged

Bump deps #4778

merged 13 commits into from Jan 2, 2023

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Dec 30, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

this PR bumps everything but rollup v3 itself for now, because of plugin terser vs rollup v3 incompat. might be fixed by: rollup/plugins#1383

Description

@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #4778 (c9c6fdf) into master (87f2027) will not change coverage.
The diff coverage is 97.05%.

@@           Coverage Diff           @@
##           master    #4778   +/-   ##
=======================================
  Coverage   99.03%   99.03%           
=======================================
  Files         217      217           
  Lines        7773     7773           
  Branches     2159     2159           
=======================================
  Hits         7698     7698           
  Misses         24       24           
  Partials       51       51           
Impacted Files Coverage Δ
cli/run/timings.ts 0.00% <0.00%> (ø)
src/Chunk.ts 99.82% <100.00%> (ø)
src/ModuleLoader.ts 100.00% <100.00%> (ø)
src/ast/nodes/ArrayExpression.ts 100.00% <100.00%> (ø)
src/ast/nodes/ConditionalExpression.ts 100.00% <100.00%> (ø)
src/ast/nodes/LogicalExpression.ts 100.00% <100.00%> (ø)
src/ast/nodes/VariableDeclaration.ts 98.05% <100.00%> (ø)
src/ast/nodes/shared/ClassNode.ts 100.00% <100.00%> (ø)
src/ast/nodes/shared/ObjectEntity.ts 100.00% <100.00%> (ø)
src/utils/FileEmitter.ts 100.00% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@Hacker011135 Hacker011135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok
192px

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Due to the update, some new unicorn linting rules got pulled in. I think they are reasonable, but you will need to adapt the code to make CI pass.

@dnalborczyk
Copy link
Contributor Author

dnalborczyk commented Dec 31, 2022

Thanks for the PR. Due to the update, some new unicorn linting rules got pulled in. I think they are reasonable, but you will need to adapt the code to make CI pass.

dang, I could have sworn I ran the linter locally. I'll fix that up.

@lukastaegert lukastaegert enabled auto-merge (squash) January 2, 2023 06:34
@lukastaegert lukastaegert merged commit e026801 into rollup:master Jan 2, 2023
@dnalborczyk dnalborczyk deleted the deps branch January 2, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants