Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default acorn options + other fixes #4786

Merged
merged 8 commits into from Jan 5, 2023

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Jan 3, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

just some things I noticed when looking through: #4784

allowHashBang and allowAwaitOutsideFunction are default with ecmaVersion: "latest"

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@6a29327). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #4786   +/-   ##
=========================================
  Coverage          ?   99.03%           
=========================================
  Files             ?      217           
  Lines             ?     7773           
  Branches          ?     2158           
=========================================
  Hits              ?     7698           
  Misses            ?       24           
  Partials          ?       51           
Impacted Files Coverage Δ
src/Bundle.ts 100.00% <ø> (ø)
src/Module.ts 100.00% <100.00%> (ø)
src/utils/PluginDriver.ts 100.00% <100.00%> (ø)
src/utils/options/normalizeInputOptions.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dnalborczyk dnalborczyk changed the title Remove default acorn options Remove default acorn options + other fixes Jan 3, 2023
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install dnalborczyk/rollup#parser-options

or load it into the REPL:
https://rollupjs.org/repl/?pr=4786

@lukastaegert lukastaegert enabled auto-merge (squash) January 5, 2023 06:52
@lukastaegert lukastaegert merged commit 67487b3 into rollup:master Jan 5, 2023
@dnalborczyk dnalborczyk deleted the parser-options branch January 5, 2023 15:39
@lukastaegert
Copy link
Member

This PR has been released as part of rollup@3.10.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants