New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove default acorn options + other fixes #4786
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4786 +/- ##
=========================================
Coverage ? 99.03%
=========================================
Files ? 217
Lines ? 7773
Branches ? 2158
=========================================
Hits ? 7698
Misses ? 24
Partials ? 51
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
23a2bee
to
f91a51d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install dnalborczyk/rollup#parser-options or load it into the REPL: |
This PR has been released as part of rollup@3.10.0. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
just some things I noticed when looking through: #4784
allowHashBang
andallowAwaitOutsideFunction
are default withecmaVersion: "latest"