Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more known globals #4886

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Mar 1, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

@netlify
Copy link

netlify bot commented Mar 1, 2023

Deploy Preview for rollupjs ready!

Name Link
🔨 Latest commit 6fbee79
🔍 Latest deploy log https://app.netlify.com/sites/rollupjs/deploys/63fec14dfae8d0000812b6b4
😎 Deploy Preview https://deploy-preview-4886--rollupjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #4886 (6fbee79) into master (1ab9833) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4886   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         219      219           
  Lines        7948     7948           
  Branches     2189     2189           
=======================================
  Hits         7867     7867           
  Misses         26       26           
  Partials       55       55           
Impacted Files Coverage Δ
src/ast/nodes/shared/knownGlobals.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dnalborczyk dnalborczyk marked this pull request as ready for review March 1, 2023 03:00
@dnalborczyk dnalborczyk marked this pull request as draft March 1, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant