Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make file name deterministic in parallel emits (fix #4909) #4912

Merged
merged 3 commits into from Mar 20, 2023
Merged

fix: make file name deterministic in parallel emits (fix #4909) #4912

merged 3 commits into from Mar 20, 2023

Conversation

sun0day
Copy link
Contributor

@sun0day sun0day commented Mar 19, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

resolves #4909

@sun0day
Copy link
Contributor Author

sun0day commented Mar 19, 2023

Can you help review this pr? @lukastaegert Thanks

@codecov
Copy link

codecov bot commented Mar 19, 2023 •
edited

Codecov Report

Merging #4912 (0129e9e) into master (680912e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4912   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files         221      221           
  Lines        8026     8030    +4     
  Branches     2209     2211    +2     
=======================================
+ Hits         7947     7951    +4     
  Misses         26       26           
  Partials       53       53
Impacted Files Coverage Δ
src/utils/FileEmitter.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

lukastaegert
lukastaegert approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukastaegert lukastaegert enabled auto-merge (squash) March 20, 2023 05:15
@lukastaegert lukastaegert merged commit 3682f30 into rollup:master Mar 20, 2023
14 checks passed
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.20.0. You can test it via npm install rollup.

@rollup-bot rollup-bot mentioned this pull request Mar 20, 2023
Closed
@sun0day sun0day mentioned this pull request Mar 20, 2023
Merged
9 tasks
@lukastaegert lukastaegert mentioned this pull request Mar 23, 2023
Merged
9 tasks
@lukastaegert
Copy link
Member

Replaced by #4919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-deterministic asset file name when multiple asset has same content with a different name
3 participants
@sun0day @rollup-bot @lukastaegert