Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: repl style add scoped #4925

Merged
merged 2 commits into from Apr 1, 2023
Merged

Conversation

btea
Copy link
Contributor

@btea btea commented Mar 31, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

The repl style does not add scoped, and the button style will affect the copy button, causing the content to be misplaced
image

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@lukastaegert lukastaegert enabled auto-merge (squash) April 1, 2023 19:33
@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #4925 (2b3f588) into master (c2cda42) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4925   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files         221      221           
  Lines        8052     8052           
  Branches     2216     2216           
=======================================
  Hits         7973     7973           
  Misses         26       26           
  Partials       53       53           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit 0bcf0a6 into rollup:master Apr 1, 2023
14 checks passed
@btea btea deleted the chore/copy-button branch April 2, 2023 01:01
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.20.3-0. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@3.20.3-0 or npm install rollup@beta. It will likely become part of a regular release later.

@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.20.3. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants