Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate global styles #4941

Merged
merged 2 commits into from Apr 18, 2023
Merged

Reinstate global styles #4941

merged 2 commits into from Apr 18, 2023

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

In a previous PR, we made all REPL styles scope. The styles in question, however, were global on purpose, which I completely overlooked. This fixes it but makes them more specific to avoid conflicts.

@vercel
Copy link

vercel bot commented Apr 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2023 4:47am

@github-actions
Copy link

github-actions bot commented Apr 17, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix-repl-styling

or load it into the REPL:
https://rollup-m9vmuer0f-rollup-js.vercel.app/repl/?pr=4941

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #4941 (d604817) into master (3bbf6ae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4941   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         223      223           
  Lines        8050     8050           
  Branches     2210     2210           
=======================================
  Hits         7968     7968           
  Misses         28       28           
  Partials       54       54           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit 532da1a into master Apr 18, 2023
11 of 12 checks passed
@lukastaegert lukastaegert deleted the fix-repl-styling branch April 18, 2023 04:57
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.20.5. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants