Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for reserved keywords used as import/export specifiers #4943

Merged

Conversation

Andarist
Copy link
Member

It's just a test as I it crossed my mind that this might need rechecking after #4939 landed. Everything works OK but having an extra test won't hurt

@vercel
Copy link

vercel bot commented Apr 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2023 7:04pm

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #4943 (b099b76) into master (09031e7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4943   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         222      222           
  Lines        8047     8047           
  Branches     2208     2208           
=======================================
  Hits         7965     7965           
  Misses         28       28           
  Partials       54       54           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Andarist Andarist changed the title Add a test for reversed keywords used as import/export specifiers Add a test for reserved keywords used as import/export specifiers Apr 18, 2023
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this 👍

@lukastaegert lukastaegert added this pull request to the merge queue Apr 18, 2023
Merged via the queue into rollup:master with commit e5691a0 Apr 18, 2023
12 checks passed
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.20.7. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants