Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #4939 for now #4946

Merged
merged 1 commit into from Apr 18, 2023
Merged

Revert #4939 for now #4946

merged 1 commit into from Apr 18, 2023

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Apr 18, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

I revert this feature until we figured out what causes build errors for some people, see #4945 and #4939 (comment)

@vercel
Copy link

vercel bot commented Apr 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview Apr 18, 2023 11:21am

@github-actions
Copy link

github-actions bot commented Apr 18, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#revert-4939

or load it into the REPL:
https://rollup-q7gp5zorm-rollup-js.vercel.app/repl/?pr=4946

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #4946 (4691cba) into master (d7d63e6) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4946      +/-   ##
==========================================
- Coverage   98.98%   98.98%   -0.01%     
==========================================
  Files         223      222       -1     
  Lines        8050     8047       -3     
  Branches     2210     2208       -2     
==========================================
- Hits         7968     7965       -3     
  Misses         28       28              
  Partials       54       54              
Impacted Files Coverage Δ
src/finalisers/es.ts 100.00% <100.00%> (ø)
src/utils/generateCodeSnippets.ts 97.29% <100.00%> (+0.15%) ⬆️
src/utils/safeName.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit 911700b into master Apr 18, 2023
12 checks passed
@lukastaegert lukastaegert deleted the revert-4939 branch April 18, 2023 11:33
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.20.6. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants