Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support default exported classes that extend other classes #4950

Merged
merged 1 commit into from Apr 21, 2023

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

The logic that automatically adds ids when default exporting anonymous classes was not prepared to handle extends properly, which lead to an instance where Rollup stalled due to an infinite loop.

@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview Apr 20, 2023 11:46am

@github-actions
Copy link

github-actions bot commented Apr 20, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-4783-default-export-extends

or load it into the REPL:
https://rollup-a0ji70zed-rollup-js.vercel.app/repl/?pr=4950

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #4950 (15b0c10) into master (e5691a0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4950   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         222      222           
  Lines        8047     8049    +2     
  Branches     2208     2210    +2     
=======================================
+ Hits         7965     7967    +2     
  Misses         28       28           
  Partials       54       54           
Impacted Files Coverage Δ
src/ast/nodes/ExportDefaultDeclaration.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit 2820962 into master Apr 21, 2023
12 checks passed
@lukastaegert lukastaegert deleted the gh-4783-default-export-extends branch April 21, 2023 04:29
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.20.7. You can test it via npm install rollup.

@rollup-bot rollup-bot mentioned this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollup stalling
2 participants