Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix REPL in dev #4964

Merged
merged 2 commits into from Apr 28, 2023
Merged

Fix REPL in dev #4964

merged 2 commits into from Apr 28, 2023

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Due to changes in latest Vite, module resolution changed so that our browser module plugin needed to be adjusted. This fixes the REPL in npm run dev.

@vercel
Copy link

vercel bot commented Apr 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 7:27pm

@github-actions
Copy link

github-actions bot commented Apr 28, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix-dev

or load it into the REPL:
https://rollup-bfyj7umzm-rollup-js.vercel.app/repl/?pr=4964

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #4964 (32767f4) into master (da74c59) will not change coverage.
The diff coverage is n/a.

❗ Current head 32767f4 differs from pull request most recent head ab678aa. Consider uploading reports for the commit ab678aa to get more accurate results

@@           Coverage Diff           @@
##           master    #4964   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         222      222           
  Lines        8112     8112           
  Branches     2236     2236           
=======================================
  Hits         8030     8030           
  Misses         28       28           
  Partials       54       54           

@lukastaegert lukastaegert merged commit 6cc3fef into master Apr 28, 2023
10 checks passed
@lukastaegert lukastaegert deleted the fix-dev branch April 28, 2023 19:42
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.21.1. You can test it via npm install rollup.

@@ -1,7 +1,7 @@
import alias from '@rollup/plugin-alias';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants