Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add options type for function tests #4988

Merged
merged 1 commit into from May 11, 2023

Conversation

TrickyPi
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

It seems that #4954 forgot to add options type to TestConfigFunction.

@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 7:38am

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #4988 (4780bd5) into master (38787ce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4988   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files         222      222           
  Lines        8133     8133           
  Branches     2239     2239           
=======================================
  Hits         8051     8051           
  Misses         28       28           
  Partials       54       54           

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukastaegert lukastaegert added this pull request to the merge queue May 11, 2023
Merged via the queue into rollup:master with commit 71cd30a May 11, 2023
12 checks passed
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.21.7. You can test it via npm install rollup.

@TrickyPi TrickyPi deleted the chore/add-type branch May 23, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants