Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mark Set, Map, WeakSet and WeakMap with array arguments as pure #5005

Merged
merged 2 commits into from May 22, 2023

Conversation

TrickyPi
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

@vercel
Copy link

vercel bot commented May 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 5:09am

@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Merging #5005 (6805cb9) into master (06e9045) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5005   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files         222      222           
  Lines        8177     8180    +3     
  Branches     2252     2253    +1     
=======================================
+ Hits         8093     8096    +3     
  Misses         30       30           
  Partials       54       54           
Impacted Files Coverage Δ
src/ast/nodes/shared/knownGlobals.ts 100.00% <100.00%> (ø)

@github-actions
Copy link

github-actions bot commented May 22, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install TrickyPi/rollup#feat/mark-pure

or load it into the REPL:
https://rollup-idphpyxvt-rollup-js.vercel.app/repl/?pr=5005

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@lukastaegert lukastaegert added this pull request to the merge queue May 22, 2023
Merged via the queue into rollup:master with commit 5ea3655 May 22, 2023
12 checks passed
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.23.0. You can test it via npm install rollup.

@TrickyPi TrickyPi deleted the feat/mark-pure branch May 23, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants