Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix turborepo with rollup --watch #5027

Merged
merged 3 commits into from Jun 9, 2023

Conversation

plumber-dhaval
Copy link
Contributor

@plumber-dhaval plumber-dhaval commented Jun 7, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

resolves vercel/turbo#4983
#5004 did not fix the issues with turbo not working in watch mode with rollup.

Unfortunately i do not have time to update/write tests but want to share what fixes the issue with turbo in our monorepo

@vercel
Copy link

vercel bot commented Jun 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2023 7:22pm

@lukastaegert
Copy link
Member

The change looks reasonable to me, and would be hard to test in the current setup. As it mirrors the behavior for the non-watch CLI to only use process.exit for non-zero exit codes, I would actually considering to merge the change as-is if all tests are green and it runs locally for me.

@lukastaegert lukastaegert marked this pull request as ready for review June 9, 2023 19:20
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #5027 (9d27a8d) into master (e3c3ee4) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5027      +/-   ##
==========================================
- Coverage   98.97%   98.96%   -0.02%     
==========================================
  Files         222      222              
  Lines        8208     8208              
  Branches     2257     2257              
==========================================
- Hits         8124     8123       -1     
  Misses         30       30              
- Partials       54       55       +1     
Impacted Files Coverage Δ
cli/run/watch-cli.ts 85.13% <0.00%> (-1.36%) ⬇️

@lukastaegert lukastaegert merged commit abd289d into rollup:master Jun 9, 2023
10 of 12 checks passed
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.24.1. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[turborepo] early exit when trying to use rollup's watch mode
3 participants