Do not add tree-shaken variables to namespaces when inlining dynamic imports #5047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-5043-inline-dynamic-import-erroror load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #5047 +/- ##
=======================================
Coverage 98.96% 98.96%
=======================================
Files 225 225
Lines 8301 8302 +1
Branches 2279 2280 +1
=======================================
+ Hits 8215 8216 +1
Misses 31 31
Partials 55 55
|
|
This PR has been released as part of rollup@3.25.3. You can test it via |
lukastaegert
added a commit
that referenced
this pull request
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This resolves an issue when
inlineDynamicImportsandimport()promise does not use the variableIt is basically a regression introduced in #4952 where we implemented tree-shaking for dynamic imports. There were two places where tree-shaken variables were not properly handled, which is fixed here.