fix: allow the name of Rollup Error to be modified #5240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #5240 +/- ##
==========================================
+ Coverage 98.80% 98.82% +0.02%
==========================================
Files 231 231
Lines 8863 8863
Branches 2317 2317
==========================================
+ Hits 8757 8759 +2
+ Misses 45 43 -2
Partials 61 61
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#xiaopi-uncaught-errorsNotice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly. or load it into the REPL: |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This PR has been released as part of rollup@4.3.1. You can test it via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Recently, I use Rollup and
@rollup/plugin-typescript(the tsconfignoEmitOnErroris true) plugin to bundle my project, I found that the error content is incorrect if this plugin throws an error by callingthis.errorfunction under watch mode.The incorrect error.
Therefore, I submitted this PR that allows the name of the Rollup Error to be modified.