Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add friendly error for missing MSVC redistributable #5284

Conversation

sapphi-red
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

(searching with ERR_DLOPEN_FAILED vite OR rollup site:stackoverflow.com gives 7 hits too)

Description

I saw many people facing ERR_DLOPEN_FAILED error caused by missing DLL on Windows.

This PR adds a message about that. I didn't find a way to obtain which DLL is missing, so I made the message a bit general.

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 3:34pm

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0b619fd) 98.86% compared to head (e01b7dc) 98.82%.

Files Patch % Lines
native.js 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5284      +/-   ##
==========================================
- Coverage   98.86%   98.82%   -0.04%     
==========================================
  Files         232      232              
  Lines        8953     8957       +4     
  Branches     2336     2336              
==========================================
+ Hits         8851     8852       +1     
- Misses         43       46       +3     
  Partials       59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks like a good idea!

@lukastaegert lukastaegert merged commit d77b682 into rollup:master Dec 7, 2023
25 of 27 checks passed
Copy link

github-actions bot commented Dec 8, 2023

This PR has been released as part of rollup@4.7.0. You can test it via npm install rollup.

@sapphi-red sapphi-red deleted the feat/add-friendly-error-for-missing-msvc-redist branch December 9, 2023 03:36
@starball5
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants