-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ppc64le #5350
Merged
Merged
Add support for ppc64le #5350
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
74e5722
Add support for ppc64le
pavolloffay 23b9308
Fix
pavolloffay 4f0090d
Fix
pavolloffay 8164d4a
Fix
pavolloffay 4a98430
Try enabling zig
pavolloffay e47ab30
Set linker via environment
lukastaegert e05cb32
Merge branch 'master' into add-ppc64le
lukastaegert File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# `@rollup/rollup-linux-ppc64le-gnu` | ||
|
||
This is the **ppc64le-unknown-linux-gnu** binary for `rollup` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
{ | ||
"name": "@rollup/rollup-linux-ppc64le-gnu", | ||
"version": "0.0.0", | ||
"os": [ | ||
"linux" | ||
], | ||
"cpu": [ | ||
"ppc64le" | ||
], | ||
"files": [ | ||
"rollup.linux-ppc64le-gnu.node" | ||
], | ||
"description": "Native bindings for Rollup", | ||
"author": "Lukas Taegert-Atkinson", | ||
"homepage": "https://rollupjs.org/", | ||
"license": "MIT", | ||
"repository": "rollup/rollup", | ||
"libc": [ | ||
"glibc" | ||
], | ||
"main": "./rollup.linux-ppc64le-gnu.node" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavolloffay @lukastaegert
I guess this line and
cpu
field in package.json need to beppc64
instead ofppc64le
.process.arch
seems to returnppc64
.https://github.com/konveyor/tackle2-ui/actions/runs/8150208242/job/22276088934#step:7:89
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you are right and
process.arch
always returnsppc64
- which in practice means ppc64le as Node hasn't been supporting big-endian Linux for a while. In theory there is also anos.machine
interface that returns eitherppc64
orppc64le
, but it doesn't seem necessary to use that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If anyone wants to make an educated PR to improve here, this would be very welcome! Otherwise, I can also have a look in the next days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR here: #5460
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sapphi-red, just wondering whether the native ppc64le rollup work fors you now? It looks like tackle2-ui downgraded to rollup v3 in the meantime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a ppc64le machine so I don't know 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spend some hours setting up emulated smoke tests for some environments including ppc64le and I can confirm it works now 😀
#5477