Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use opt-level=z for browser wasm #5494

Merged

Conversation

sapphi-red
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

I think the file size is more important than speed for browser builds. This reduces the file size by ~27% when compressed.

uncompressed: 1,652,392B -> 466,856B
compressed(gzip): 939,788B -> 338,906B

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 7:05am

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.81%. Comparing base (b5560a7) to head (4031cbe).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5494   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         238      238           
  Lines        9451     9451           
  Branches     2408     2408           
=======================================
  Hits         9339     9339           
  Misses         47       47           
  Partials       65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that is definitely a very useful change!

@lukastaegert lukastaegert added this pull request to the merge queue Apr 27, 2024
Merged via the queue into rollup:master with commit db19272 Apr 27, 2024
36 checks passed
@sapphi-red sapphi-red deleted the feat/use-opt-level-z-for-browser-wasm branch April 27, 2024 09:56
Copy link

This PR has been released as part of rollup@4.17.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants