Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug release issues #5496

Closed
wants to merge 1 commit into from
Closed

Debug release issues #5496

wants to merge 1 commit into from

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

For some reasons, artifacts are created with the wrong names

Copy link

vercel bot commented Apr 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2024 7:54am

Copy link

github-actions bot commented Apr 27, 2024

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#debug-napi-issues

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-nm7azb3t3-rollup-js.vercel.app/repl/?pr=5496

Copy link

github-actions bot commented Apr 27, 2024

Performance report!

Rough benchmark

Command Mean [s] Min [s] Max [s] Relative
node _benchmark/previous/bin/rollup -i ./perf/entry.js -o _benchmark/result/previous.js 9.145 ± 0.117 9.017 9.246 1.01 ± 0.02
node _benchmark/current/bin/rollup -i ./perf/entry.js -o _benchmark/result/current.js 9.010 ± 0.116 8.876 9.078 1.00

Internal benchmark

BUILD: 7909ms (-72ms, -0.9%), 751 MB

initialize: 0ms, 24.4 MB (+8%)

generate module graph: 3066ms (-10ms, -0.3%), 575 MB

generate ast: 1455ms (-26ms, -1.8%), 568 MB

sort and bind modules: 437ms, 615 MB

mark included statements: 4398ms (-20ms, -0.5%), 751 MB

treeshaking pass 1: 1493ms (-14ms, -0.9%), 716 MB
treeshaking pass 2: 721ms, 740 MB
treeshaking pass 3: 279ms, 745 MB
treeshaking pass 4: 260ms, 744 MB
treeshaking pass 5: 302ms, 749 MB
treeshaking pass 6: 248ms, 750 MB
treeshaking pass 7: 230ms, 749 MB
treeshaking pass 8: 224ms, 747 MB
treeshaking pass 9: 203ms, 754 MB
treeshaking pass 10: 206ms, 752 MB
treeshaking pass 11: 203ms, 751 MB

GENERATE: 863ms, 1.02 GB

initialize render: 0ms, 914 MB

generate chunks: 80ms (-27ms, -25.5%), 922 MB

optimize chunks: 0ms, 915 MB

render chunks: 764ms, 1 GB

transform chunks: 16ms, 1.02 GB

generate bundle: 0ms, 1.02 GB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant